Skip to content

Release/version 0.1.0 #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Release/version 0.1.0 #5

wants to merge 13 commits into from

Conversation

@piratejas
Copy link
Contributor

@piratejas piratejas commented Jun 23, 2023

What

  • Created Basic file structure
  • Updated README.md with instructions on how to run the application
  • Updated Contributing.md with some basic rules for the commit template
  • Added new feature: create new bid and post route to write into memory (txt file)
  • Written unit tests for routes
  • Organised folder structure

How to review

  • Run pytest command in terminal to run tests
  • Send request to route via Rest Client or Postman to check successful response (use test_request.http)
  • Review folder structure and naming conventions for sense check

Who can review

@nshumoogum

Lakorthus and others added 13 commits June 20, 2023 12:53
@Lakorthus @piratejas
Create Hello world endpoint
2089170 
Co-authored-by: Pira Tejasakulsin <[email protected]>
@piratejas
tested and updated readme instructions for running app
1571f0a
@Lakorthus @piratejas
test: test_hello_world controller function.
ea1d499 
Co-authored-by: Pira Tejasakulsin <[email protected]>
@Lakorthus
test: routes on hello_world
0af031b
@Lakorthus
Merge pull request #2 from methods/feat_hello_world
b0d5802 
Bids API: Create Hello world endpoint
@piratejas @Lakorthus
feat: added and manually tested post route for bid
63c02ba 
Co-authored-by: Julio Velezmoro <[email protected]>
@Lakorthus @piratejas
feat: saving data in memory and separating logic
ac87d4e 
Co-authored-by: Pira Tejasakulsin <[email protected]>
@piratejas @Lakorthus
wip: add phase info to success/failed
d1f230c 
Co-authored-by: Julio Velezmoro <[email protected]>
@piratejas @Lakorthus
feat: field validation, set status enum
53d3913 
Co-authored-by: Julio Velezmoro <[email protected]>
@piratejas
test: add post bid route tests
3d0dc1c
@piratejas
Merge pull request #3 from methods/feat/create-new-bid
7641b4b 
Feat/create new bid
@piratejas
fix: renamed files and folders for readability
2d6d8cf
@piratejas
Merge pull request #4 from methods/fix/filenames-improvement
65901b1 
fix: renamed files and folders for readability
@piratejas piratejas requested a review from nshumoogum June 23, 2023 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nshumoogum nshumoogum Awaiting requested review from nshumoogum

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@piratejas @Lakorthus